JPERF-273: Generalize Jira installation API #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzyromski-atlassian
previously approved these changes
Feb 2, 2021
...main/kotlin/com/atlassian/performance/tools/infrastructure/api/jira/install/InstalledJira.kt
Show resolved
Hide resolved
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-installs
branch
from
4abfc53
to
4847966
Compare
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-installs
branch
3 times, most recently
from
4847966
to
a3530b9
Compare
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-installs
branch
from
fafa5e3
to
5ccc228
Compare
It's [`RemoteLocation`] from aws-infrastructure, but without the AWS bits. [`RemoteLocation`]: https://github.com/atlassian/aws-infrastructure/blob/release-2.22.2/src/main/kotlin/com/atlassian/performance/tools/awsinfrastructure/api/RemoteLocation.kt
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-installs
branch
from
5ccc228
to
6cac170
Compare
|
Resolved conflicts |
dagguh
commented
Feb 15, 2021
Comment on lines
+29
to
+32
| val serverXml = installed | ||
| .installation | ||
| .resolve("conf/server.xml") | ||
| .download(Files.createTempFile("downloaded-config", ".xml")) |
There was a problem hiding this comment.
That's what we get when we upgrade a primitive String to an object 😃
Good catch about ambiguity of installation: String @mzyromski-atlassian 👍
mzyromski-atlassian
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.