Generalize Jira start API #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2021
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-starts
branch
2 times, most recently
from
11f32fc
to
4bfee89
Compare
dagguh
force-pushed
the
issue/JPERF-273-generalize-jira-starts
branch
from
4bfee89
to
fd31f40
Compare
dagguh
commented
Feb 19, 2021
|
|
||
| @Test | ||
| fun shouldInstallJira() { | ||
| // given | ||
| val installation = ParallelInstallation( | ||
| jiraHomeSource = EmptyJiraHome(), | ||
| productDistribution = PublicJiraSoftwareDistribution("7.13.0"), | ||
| jdk = AdoptOpenJDK11() |
There was a problem hiding this comment.
Turns out that Jira 7.13.0 didn't like this JDK during start:
Wrong JVM version! You are running with openjdk version "11.0.1" 2018-10-16 but JIRA requires at least 1.8 to run.
dagguh
commented
Feb 19, 2021
| import com.atlassian.performance.tools.infrastructure.toSsh | ||
| import com.atlassian.performance.tools.sshubuntu.api.SshUbuntuContainer | ||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.Test | ||
| import java.nio.file.Files | ||
| import java.util.function.Consumer | ||
|
|
||
| class ParallelInstallationIT { | ||
| class JiraLaunchScriptIT { |
There was a problem hiding this comment.
I'm renaming the integration test to point to the biggest top-level chunk. E.g now it tests both ParallelInstallation and JiraLaunchScript, but the launch script goes further and relies on the installation, so it encompasses a bigger chunk of the system. When I'll add hooks API, they will be the top level.
mzyromski-atlassian
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #100