Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook into Jira provisoning #102

Closed
wants to merge 1 commit into from
Closed

Hook into Jira provisoning #102

wants to merge 1 commit into from

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Feb 12, 2021

Depends on #101

@dagguh dagguh mentioned this pull request Feb 12, 2021
Draft
@dagguh dagguh force-pushed the issue/JPERF-273-jira-hooks branch 2 times, most recently from e2da917 to 77ef790 Compare February 19, 2021 12:45
@dagguh dagguh marked this pull request as ready for review February 26, 2021 14:07
@dagguh dagguh requested a review from a team as a code owner February 26, 2021 14:07
dagguh
dagguh commented Feb 26, 2021
View reviewed changes
...otlin/com/atlassian/performance/tools/infrastructure/api/jira/install/hook/DataCenterHook.kt
) {
val localSharedHome = sharedHome.localSharedHome
sharedHome.mount(ssh)
val jiraHome = jira.home.path // TODO what's the difference between localSharedHome and jiraHome? should both be hookable?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove the DataCenterHook until we get a DC test

src/main/kotlin/com/atlassian/performance/tools/infrastructure/api/jira/report/StaticReport.kt
private val remotePath: String
) : Report {

override fun locate(ssh: SshConnection): List<String> = listOf(remotePath)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It assumes that the ssh will connect to the same server as when it got the remotePath during construction.
Might get messy when we get DC hooks support. It'd probably need to return a List<RemotePath> and higher layers will have to deal with paths coming from different hosts.

@dagguh dagguh mentioned this pull request Feb 26, 2021
Draft
mzyromski-atlassian
mzyromski-atlassian approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@mzyromski-atlassian mzyromski-atlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagguh, this work is awesome!

@dagguh
Copy link
Contributor Author

dagguh commented Mar 12, 2021 •
edited
Loading

Thanks! ❤️
I'm working on Data Center version of this: #103. And it seems the abstractions here are insufficient. We need to distinguish a Jira instance from a Jira node. And an instance home from node home (shared home vs local home). I'll put it back into draft. When this is compatible with DC, I will still reduce the scope of the PR to just Server in order to keep it small enough.

@dagguh dagguh marked this pull request as draft March 12, 2021 10:53
@dagguh
Copy link
Contributor Author

dagguh commented Mar 2, 2023

Obsoleted by #103

@dagguh dagguh closed this Mar 2, 2023
@dagguh dagguh deleted the issue/JPERF-273-jira-hooks branch March 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzyromski-atlassian mzyromski-atlassian mzyromski-atlassian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagguh @mzyromski-atlassian