Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial code actions backend for Linter service #139

Merged
merged 21 commits into from
May 14, 2021
Merged

feat: initial code actions backend for Linter service #139

merged 21 commits into from
May 14, 2021

Conversation

aminya
Copy link
Member

@aminya aminya commented Mar 19, 2021 •
edited
Loading

  • Moves the old atom-ide-diagnostics code to a separate adapter
  • Adds initial code actions support for the Linter package -> The packages themselves have not implemented this yet

@aminya aminya mentioned this pull request Mar 19, 2021
Closed
@aminya aminya added the enhancement New feature or request label Apr 2, 2021
@aminya aminya force-pushed the code-actions branch 2 times, most recently from 09ba7e5 to ea2a300 Compare April 2, 2021 12:01
aminya
aminya commented Apr 2, 2021
View reviewed changes
lib/adapters/linter-push-v2-adapter.ts
linterName: diagnostic.source,
severity: lsSeverityToV2MessageSeverity(diagnostic.severity ?? DiagnosticSeverity.Error),
// BLOCKED: on steelbrain/linter#1722
solutions: undefined,
Copy link
Member Author

@aminya aminya Apr 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to provide solutions from Ls.Diagnostic. We need to first update Linter package

@bennypowers
Copy link
Member

Can you show us a screenshot of the UI?

are there new commands like "show solutions under cursor" or "apply solutions" or something?

@aminya
Copy link
Member Author

aminya commented Apr 4, 2021 •
edited
Loading

Can you show us a screenshot of the UI?

are there new commands like "show solutions under cursor" or "apply solutions" or something?

This is the backend adapter for code actions. The UI isn't implemented yet.

We need to fix these two issues to support the UI as well
steelbrain/linter-ui-default#611
steelbrain/linter#1722

@aminya aminya changed the title Code Actions feat: update code actions Apr 13, 2021
aminya and others added 17 commits May 14, 2021 02:04
@aminya
chore: add updateMessageKey function
8fab8c9
@aminya
chore: add getMessageKey
ea81ad0
@aminya @illright
chore: convert relatedInformationToReference
fdfd05a 
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
@aminya @illright
chore: add iconForLSSeverity
966d5a7 
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
@aminya @illright
chore: add lsSeverityToV2MessageSeverity
d4ae9cb 
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
@aminya @illright
chore: add lsDiagnosticToV2Message
8c3b082 
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
@aminya @illright
feat: add getLSDiagnostic for Linter adapter
3671896 
Co-Authored-By: Lev Chelyadinov <15035286+illright@users.noreply.github.com>
@aminya @illright
fix: use connection.executeCommand from LS
2c62bf6 
Co-Authored-By: Lev Chelyadinov <15035286+illright@users.noreply.github.com>
@aminya
feat: add getLSDiagnostics for Linter adapter
e878b8d
@aminya
chore: move and deprecate atomIde.Diagnostic methods
21db0f6
@aminya
feat: add deorecated IdeDiagnosticAdapter
743aede
@aminya
chore: rename linter getLSDiagnostic functions + protected props
7af552f
@aminya
feat: add IdeDiagnosticAdapter methods for conversion to ls.Diagnostics
059af66 
extend form Linter
@aminya
feat: update getCodeActions and createCodeActionParams
1c5430a
@aminya @illright
feat: codeActionResolve in languageClient
a9ca617 
Co-Authored-By: Lev Chelyadinov <illright@users.noreply.github.com>
@aminya
test: move IdeDiagnostics tests
d6b0685
@aminya
test: fix getCodeActions tests
e8ab567
@aminya aminya marked this pull request as ready for review May 14, 2021 07:06
aminya
aminya commented May 14, 2021
View reviewed changes
Copy link
Member Author

@aminya aminya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged as of its current state because it is backward compatible and the changes are tested. We should update it later again once Linter and Linter-ui-default actually implemented the UI for this. We can't do anything else here for now.

Because the changes edit multiple files, we should merge this first before we can fix #156

@aminya aminya requested a review from UziTech May 14, 2021 07:17
@aminya aminya changed the title feat: update code actions feat: initial code actions backend for Linter service May 14, 2021
UziTech
UziTech approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aminya aminya merged commit 33887a6 into master May 14, 2021
@aminya aminya deleted the code-actions branch May 14, 2021 14:37
@github-actions
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ewanharris ewanharris mentioned this pull request Jun 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminya @bennypowers @UziTech