-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow solutions to be an async callback #1722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
solutions-callback
branch
2 times, most recently
from
January 5, 2021 03:27
69d35d0
to
c142b55
Compare
aminya
force-pushed
the
solutions-callback
branch
from
January 5, 2021 03:51
c142b55
to
60b5c83
Compare
aminya
force-pushed
the
solutions-callback
branch
from
April 3, 2021 01:52
60b5c83
to
6d7358e
Compare
aminya
force-pushed
the
solutions-callback
branch
2 times, most recently
from
April 4, 2021 21:16
61cd989
to
15ef0df
Compare
aminya
force-pushed
the
solutions-callback
branch
from
April 14, 2021 06:45
15ef0df
to
83d940a
Compare
aminya
force-pushed
the
solutions-callback
branch
from
April 14, 2021 08:44
1438458
to
4abdb81
Compare
aminya
commented
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this for now as it seems there is nothing much to do here. Next, we should fix linter-ui-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter part of the equation seems to be set!
#1705