Make updateProcessEnv async and add core:loaded-shell-environment activation hook
#13200
Conversation
Signed-off-by: Nathan Sobo <nathan@github.com>
Signed-off-by: Nathan Sobo <nathan@github.com>
| if (error) { | ||
| if (error.handle) { | ||
| error.handle() | ||
| } | ||
| console.log('warning: ' + env.SHELL + '-ilc "command env" failed with signal (' + error.signal + ')') |
There was a problem hiding this comment.
It is possible that the exit code is non-zero but there is no error.
There was a problem hiding this comment.
Unfortunately execFile doesn't expose a status property. However, in my testing it seems to be reporting an error when commands exit with non-zero codes (e.g. for a bogus option like ls -j).
There was a problem hiding this comment.
Ahh, got it. Makes sense...
Make `updateProcessEnv` async and add `core:loaded-shell-environment` activation hook
Make `updateProcessEnv` async and add `core:loaded-shell-environment` activation hook
Summary: Default mercurial install location is: `/usr/local/bin`. With atom/atom#13200 - Atom may have unprepared environment when activating packages, which in case of some packages, trigger `hg` calls. Reviewed By: vjeux Differential Revision: D4193211 fbshipit-source-id: ffb6be9fe9b46dc7adf834f258053165db12b36a
@as-cii, Could you call this hook when package has been installed via package manager? I've tried to use this hook for @platformio IDE and new release broke installation process. Users need to manually restart Atom and only after it package will be activated. Thanks! |
|
@ivankravets you point out a key bug in the current implementation: if a user disables a package dependent on this hook for activation, or if a user installs a new package dependent on this hook, or if a user updates a package dependent on this hook, it will fail to activate. |
|
I made hot fix for PlatformIO IDE that adds this hook ONLY when Atom is >=1.12.2 and ony after install/upgrade procedure. Default IDE's manifest doesn't contain activation hooks. Nevertheless, IDE will add them after first installation. |
Fixes #9406.
Fixes #13084.
When Atom is launched from the Dock, we invoke the user shell to retrieve environment variables that are assigned by their profile settings. However, we were doing so synchronously during startup, thus causing a major slowdown when opening Atom from the Dock and sometimes hanging the startup process indefinitely.
With this pull request, we are changing
updateProcessEnvinto an asynchronous method. Packages that require shell environment variables to be assigned prior to activation can use the newcore:loaded-shell-environmentactivation hook by putting the following snippet inpackage.json:{"activationHooks": ["core:loaded-shell-environment"]}This will defer packages' activation until
process.envhas been updated with the user environment variables./cc: @atom/maintainers