Adding ci with atom-beta on CircleCI

[kn1kn1]

This PR adds ci with atom-beta on CircleCI.

Adding environment variable ATOM_CHANNEL: "beta" to circle.yml enables ci with atom-beta.

dependencies:
  override:
    - curl -s -O https://raw.githubusercontent.com/atom/ci/master/build-package.sh
    - chmod u+x build-package.sh

test:
  override:
    - ./build-package.sh

machine:
  environment:
    ATOM_LINT_WITH_BUNDLED_NODE: "true"
    APM_TEST_PACKAGES: ""
    ATOM_CHANNEL: "beta"

• Example circle.yml file
  https://github.com/kn1kn1/language-context-free/blob/atom-beta/circle.yml

• Example CircleCI result
  https://circleci.com/gh/kn1kn1/language-context-free/277

Please note: this change will not affect current circle.yml for atom stable version.

[steelbrain]

A friendly bump, it'll be nice to have this land sooner. I have to maintain a build-package.sh separately on a gist because of this

[Arcanemagus]

@kn1kn1 This has merge conflicts that need to be fixed btw.

[kn1kn1]

resolved.

CircleCI result:
https://circleci.com/gh/kn1kn1/language-context-free/327

[Arcanemagus]

Can you include specification of the ATOM_CHANNEL variable in the circle.yml file to expose this capability there?

[kn1kn1]

Can this comment be suitable for the spec or any alternatives?

dependencies:
  override:
    - curl -s -O https://raw.githubusercontent.com/atom/ci/master/build-package.sh
    - chmod u+x build-package.sh

test:
  override:
    - ./build-package.sh

machine:
  environment:
    ATOM_LINT_WITH_BUNDLED_NODE: "true"
    APM_TEST_PACKAGES: ""
    # ATOM_CHANNEL: "beta"  # "stable" or "beta". Default is "stable".

[Arcanemagus]

I would just do:

# ... stuff
machine:
  environment:
    ATOM_LINT_WITH_BUNDLED_NODE: "true"
    APM_TEST_PACKAGES: ""
    ATOM_CHANNEL: "stable"

The other configs work the same way (explicitly setting stable).

[kn1kn1]

@Arcanemagus Thanks. I did so.

CircleCI result: https://circleci.com/gh/kn1kn1/language-context-free/329

[Arcanemagus]

LGTM

[joefitzgerald]

I would invert the logic here, so that if ATOM_CHANNEL is unset, stable is implicitly used.

[Arcanemagus]

If it's unset it defaults to stable:

ci/build-package.sh

Line 3 in 9b5325f

ATOM_CHANNEL="${ATOM_CHANNEL:=stable}"

[kn1kn1]

Is there anything else for this pr to be merged?

[Arcanemagus]

This is especially relevant now that CircleCI 2.0 is out of beta and you can do nice things like setup workflows where you build stable and beta in parallel (like Travis CI does).

[kn1kn1]

You'd better tell me that earlier as CircleCi 2.0 beta is out last month.

[Arcanemagus]

@kn1kn1 Any reason you closed this? The fixes in here are still necessary to support beta builds!

[kn1kn1]

@Arcanemagus If you really think so, you can open another pr.

[joefitzgerald]

@kn1kn1 it sounds like you've been put off by the conversation in this PR. If I have contributed to that in any way, my apologies. We do value the contribution! Merging.

[Arcanemagus]

Thanks @joefitzgerald!