Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Adding ci with atom-beta on CircleCI #62

Merged
merged 4 commits into from
Aug 15, 2017
Merged

Adding ci with atom-beta on CircleCI #62

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41fbe82
Add process for atom-beta on CircleCI
kn1kn1 Jan 13, 2017
785ff63
:art: Remove redundant variable
kn1kn1 Jan 13, 2017
c254ec7
Merge branch 'master' into feature/atom-beta-circleci
kn1kn1 Aug 8, 2017
f07f3d3
Add ATOM_CHANNEL setting explicitly
kn1kn1 Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions build-package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,13 @@ elif [ "${CIRCLECI}" = "true" ]; then
sudo dpkg --install atom-amd64.deb || true
sudo apt-get update
sudo apt-get --fix-broken --assume-yes --quiet install
export ATOM_SCRIPT_PATH="atom"
export APM_SCRIPT_PATH="apm"
if [ "${ATOM_CHANNEL}" = "stable" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would invert the logic here, so that if ATOM_CHANNEL is unset, stable is implicitly used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's unset it defaults to stable:

ci/build-package.sh

Line 3 in 9b5325f

ATOM_CHANNEL="${ATOM_CHANNEL:=stable}"

export ATOM_SCRIPT_PATH="atom"
export APM_SCRIPT_PATH="apm"
else
export ATOM_SCRIPT_PATH="atom-${ATOM_CHANNEL}"
export APM_SCRIPT_PATH="apm-${ATOM_CHANNEL}"
fi
export NPM_SCRIPT_PATH="/usr/share/atom/resources/app/apm/node_modules/.bin/npm"
;;
darwin*)
Expand Down