Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

-> operator doesnt tokenize correctly #177

Open
drewcassidy opened this issue Nov 28, 2016 · 5 comments
Open

-> operator doesnt tokenize correctly #177

drewcassidy opened this issue Nov 28, 2016 · 5 comments
Labels

Comments

@drewcassidy
Copy link

drewcassidy commented Nov 28, 2016

The -> operator does not tokenize correctly, evident when using a font with code ligatures like Fira Code. Instead it is tokenized as a - and a >.

screen shot 2016-11-28 at 9 28 51 am

it should be part of a single span:
screen shot 2016-11-28 at 9 30 50 am

In the developer console, it currently shows as this:

<span class="keyword operator c">-</span>
<span class="keyword operator comparison c">></span>
@winstliu winstliu added the bug label Nov 28, 2016
@thomasjo
Copy link
Contributor

For reference this has nothing to do with ligatures, that's just a side effect. The real bug here is that the dereference operator is not being matched properly (which is evident from the description above).

@drewcassidy drewcassidy changed the title -> operator doesnt tokenize correctly for ligatures -> operator doesnt tokenize correctly Jan 2, 2017
@winstliu
Copy link
Contributor

winstliu commented Jan 9, 2017

Code for easy copy/paste testing:

_interrupt->fall(this, &Button::trigger);

@drewcassidy
Copy link
Author

It looks like it happens with any dereferenced call to a function on an object, but not variables

@meyfa
Copy link

meyfa commented Apr 21, 2017

Apparently fixed by #195. I think this should be closed.

@winstliu
Copy link
Contributor

Nope, this is still a problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants