This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix for improper highlighting within the pointer access operator #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstliu
reviewed
Jan 9, 2017
| @@ -286,7 +286,7 @@ | |||
| 'name': 'punctuation.separator.pointer-access.c' | |||
| '4': | |||
| 'name': 'variable.other.member.c' | |||
| 'match': '((\\.)|(->))([a-zA-Z_][a-zA-Z_0-9]*)\\b(?!\\s*\\()' | |||
| 'match': '((\\.)|(->)\\s*)([a-zA-Z_][a-zA-Z_0-9]*)\\b(?!\\s*\\()' | |||
There was a problem hiding this comment.
I think the pattern should be ((\\.)|(->))\\s* instead. This is assuming C allows spaces in scenarios like a. b.
|
I would also appreciate a spec to test against any regressions. |
added 2 commits
January 9, 2017 14:10
Update spec for tokenizing of dot access operator and pointer access operator
|
Looks good, thanks! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This is a fix for issue #194 - any whitespace after a pointer access operator (->) would make tokenizing the operator fail, which in turn would impact syntax highlighting and any ligatures for that operator.
This change updates the regular expression used to identify valid uses of the pointer access operator to include operators directly followed by whitespace.
Benefits
Whitespace can now be added after a pointer access operator without affecting syntax highlighting or ligatures.
Possible Drawbacks
None. The change is minor.