🐛 Fix payments recognition during advances #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
changed the title
|
Verified with random start heights reindexing on the testnet. Before
Expected:
|
| self.logger.info(f'advance_txs: found valid subrealm payment create_or_delete_subname_payment_output_if_valid {hash_to_hex_str(tx_hash)}') | ||
| append_hashX(double_sha256(payment_tx_hash)) | ||
| append_hashX(double_sha256(subrealm_payment_tx_hash)) | ||
| self.put_op_data(tx_num, tx_hash, "payment-subrealm") |
There was a problem hiding this comment.
Is it necessary to write the corresponding operation based on the successful payment status of payment? Like payment-subrealm and payment-subrealm-failed
|
Per offline discussion, op record should indicate if the payment is failed, for example, |
electrumx/server/block_processor.py
Outdated
| @@ -2209,7 +2208,8 @@ def get_raw_mint_info_by_atomical_id_notused(self, atomical_id): | |||
| # Get the atomical details base info | |||
| # Does not retrieve the active b'a' locations in this method because there could be many thousands (in the case of FTs) | |||
| # Another method is provided to layer on the active location and gives the user control over whether to retrieve them | |||
| def get_base_mint_info_by_atomical_id(self, atomical_id): | |||
| def get_base_mint_info_by_atomical_id(self, atomical_id, height: int = None): | |||
There was a problem hiding this comment.
"None" is incompatible with "int"
There was a problem hiding this comment.
Replaced with Optional[int].
shadowv0vshadow
approved these changes
May 11, 2024
This was referenced May 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verified status of an Atomical relies on the reveal window. The height in the query is the latest advanced block height rather than the processing height, which leads to an incorrect verified status for the container and realm.
The issue used to produce incorrect block hashes, probably incorrect Atomicals assets.
See height:
txrecords below for more details on the testnet:b756276cdd06cc188c0266010c9fbf3e416089967a898275ca2909b93081f3cea98015464f0859b5f56011b4c0fb8911a83cac61cd77730744447919c79471a0