Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Improve transaction operations #181

Merged
merged 9 commits into from
May 13, 2024
Merged

⚡️ Improve transaction operations #181

merged 9 commits into from
May 13, 2024

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented May 12, 2024 •
edited
Loading

  1. Abstracts AtomicalsCoinMixin which provides height information.
  2. Merges transaction detail handlers in sessions into a single one and puts it under the SessionManager.
  3. Adds payment-subrealm-failed and payment-dmitem-failed operation value.
  4. Uses stored op value instead of massive conditions.
  5. Adds blockchain.atomicals.transaction_global for the RPC session.

@AlexV525
Copy link
Contributor Author

This also addresses #180 (comment).

@AlexV525 AlexV525 marked this pull request as ready for review May 12, 2024 15:31
@AlexV525 AlexV525 mentioned this pull request May 12, 2024
Closed
shadowv0vshadow
shadowv0vshadow approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@shadowv0vshadow shadowv0vshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's very good.

@atomicals atomicals merged commit cf23374 into develop May 13, 2024
2 checks passed
@AlexV525 AlexV525 deleted the feat/improve-op branch May 13, 2024 13:20
@AlexV525 AlexV525 mentioned this pull request May 13, 2024
Merged
Emmyjago
Emmyjago reviewed Jul 29, 2024
View reviewed changes
Copy link

@Emmyjago Emmyjago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emmyjago Emmyjago Emmyjago left review comments

@shadowv0vshadow shadowv0vshadow shadowv0vshadow approved these changes

@atomicals atomicals atomicals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexV525 @atomicals @Emmyjago @shadowv0vshadow