Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ObjectLiteral.resolveType (Related to issue#140) #168

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

valq7711
Copy link
Collaborator

@valq7711 valq7711 commented Jul 5, 2018

bugs are fixed:

h = {a: None, b: 123}  # - causes an error because of the trying expected.indexOf("Function"), but expected==null
h = {a: None, b: None} # - is resolved to '{String:null}' - deadlock hash!  '{String:?}' is more suitable, isn't it?
h = {a: def(): ...; , b: def(x): ...;, c: 123} # - is resolved to '{String:Function}', because of the premature return without checking the remaining elements

valq7711 added 2 commits July 5, 2018 23:22
bugs are fixed:
```
h = {a: None, b: 123}  # - causes an error because of the trying expected.indexOf("Function"), but expected==null
h = {a: None, b: None} # - is resolved to '{String:null}' - deadlock hash!  '{String:?}' is more suitable, isn't it?
h = {a: def(): ...; , b: def(x): ...;, c: 123} # - is resolved to '{String:Function}', because of the premature return without checking the remaining elements
```
@valq7711 valq7711 mentioned this pull request Jul 6, 2018
@valq7711
Copy link
Collaborator Author

@atsepkov
Just for clarity: it doesn't drop typed hash logic, but fixes small bugs and makes the behaviour more expected.
Try h = {a: None, b: 1} - 100% compilation error!

@valq7711 valq7711 closed this Jul 12, 2018
@valq7711 valq7711 reopened this Jul 12, 2018
@valq7711 valq7711 merged commit 5c62786 into atsepkov:master Oct 19, 2018
@valq7711 valq7711 deleted the patch-13 branch September 25, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant