Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #154 #169

Merged
merged 4 commits into from
Jul 10, 2018
Merged

fix issue #154 #169

merged 4 commits into from
Jul 10, 2018

Conversation

valq7711
Copy link
Collaborator

@valq7711 valq7711 commented Jul 6, 2018

Now PR #156 pass all tests! (merged with this PR)

@valq7711
Copy link
Collaborator Author

valq7711 commented Jul 6, 2018

@atsepkov
Hi, Alexander! It is just a few lines of code that fix important issues.
Have a look, please! + #168, #156

@@ -881,7 +881,7 @@ def parse($TEXT, options):
atom = expr_atom(False)
expect(")")
nonlocal parent
parent = atom.name
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import mod
class Bar(mod.Foo):  # atom is ast.Dot without name attr, so parent = atom.name = undefined
    def __init__(self):
        mod.Foo.__init__(self)  
        ...

@atsepkov atsepkov merged commit 0c670f8 into atsepkov:master Jul 10, 2018
@valq7711 valq7711 deleted the patch-14 branch September 25, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants