fix: Monitor/sync bug while using at_chops with pkam from secure element #1050
Conversation
…n-foundation/at_client_sdk into monitor_bug_secure_element
murali-shris
changed the title
|
@murali-shris Is there a bug with the sync's connection auth also, or is it just the monitor? |
|
Oh ignore previous question I see you have changed RemoteSecondary |
| @@ -676,5 +683,32 @@ void main() { | |||
| () async => await monitor.getQueueResponse(maxWaitTimeInMillis: 10), | |||
| throwsA(predicate((dynamic e) => e is AtClientException))); | |||
| }); | |||
| group('A group of tests for monitor when useAtChops is true', () { | |||
There was a problem hiding this comment.
We should also have an additional auth test for RemoteSecondary for when useAtChops is true
There was a problem hiding this comment.
authenticate and authenticateCram methods in RemoteSecondary are no longer used.
executeVerb and executeCommand methods in RemoteSecondary, delegates the call to atLookup which does the auth.
Can I explore writing tests for AtLookup auth?
|
Oh I see. No need for any more then. Will approve and merge. |
|
Please don't publish yet, we've not published 3.0.60 so we should probably change version back to 3.0.60 to prevent any confusion |
- What I did
- How I did it
- How to verify it
closes atsign-foundation/at_libraries#351