Values of kernel parameters cannot contain spacesNospacevalue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new type is added
```puppet
grubby::kernel_opt{'foo':
ensure => present,
value => 'bar',
scope => 'ALL',
}
```
The previous hash parameter `grubby::kernel_opts` is still valid
and now uses `grubby::kernel_opt` internally.
Motivation here is to increase flexibility of module allowing
kernel parameters to be added by other distinct modules.
While according https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters.html parameter values can be specified as a space separated list ``` param="A B" ``` it is not obvious that grubby supports such an addition. So best to fail if presented with a space containing value. If ever required check branch here atsonkov#11
|
#8 first |
|
Thanks a lot for the speedy reviews and comments. I think for now we are there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While according
https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-para
parameter values can be specified as a space separated list
it is not obvious that grubby supports such an addition.
So best to fail if presented with a space containing value.
If ever required check branch here
#11