Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-831:[frontend]feat: add pipeline is future time check #1112

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

weiraneve
Copy link

Summary

...

Before

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

After

Description

Screenshots
If applicable, add screenshots to help explain behavior of your code.

Note

Null

@weiraneve weiraneve requested a review from guzhongren March 5, 2024 04:10
Copy link

codacy-production bot commented Mar 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (92a6df0) 5739 5739 100.00%
Head commit (bc7b5b0) 11478 (+5739) 11478 (+5739) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1112) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Mar 5, 2024

Hi @weiraneve! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

Copy link
Collaborator

@guzhongren guzhongren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@@ -304,6 +304,49 @@ describe('MetricsStep', () => {
).toBeInTheDocument();
});

it('should render no pipeline container when get pipeline when selected future time ', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 when

for given, append now is 2024-01-01

jest.useRealTimers();
});

it('should render pipeline container when get pipeline when selected past time ', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 when

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@weiraneve weiraneve merged commit 213b20a into main Mar 5, 2024
49 checks passed
@weiraneve weiraneve deleted the ADM-831 branch March 5, 2024 06:49
weiraneve added a commit that referenced this pull request Mar 6, 2024
weiraneve added a commit that referenced this pull request Mar 7, 2024
weiraneve added a commit that referenced this pull request Mar 7, 2024
* Revert "ADM-831:[frontend]feat: add pipeline is future time check (#1112)"

This reverts commit 213b20a.

* Revert "ADM-831:[frontend]feat: add pipeline is future time check (#1110)"

This reverts commit a138df4.

* ADM-831:[frontend]feat: add future time check for metrics step

* ADM-831:[frontend]test: add test for pipeline metrics future time check

* Revert "ADM-831:[frontend]test: add test for pipeline metrics future time check"

This reverts commit a3c12b5.

* Revert "ADM-831:[frontend]feat: add future time check for metrics step"

This reverts commit 3d3f44d.

* ADM-831:[frontend]feat: add future time check for metrics step

* ADM-831:[frontend]refactor: adjust import code

* ADM-831:[frontend]test: add test for pipeline metrics future time check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants