-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADM-831:[frontend]feat: add pipeline is future time check #1112
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Hi @weiraneve! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
@@ -304,6 +304,49 @@ describe('MetricsStep', () => { | |||
).toBeInTheDocument(); | |||
}); | |||
|
|||
it('should render no pipeline container when get pipeline when selected future time ', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 when
for given, append now is 2024-01-01
jest.useRealTimers(); | ||
}); | ||
|
||
it('should render pipeline container when get pipeline when selected past time ', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 when
Quality Gate passed for 'heartbeat-backend'Issues Measures |
Quality Gate passed for 'au-heartbeat-heartbeat-frontend'Issues Measures |
)" This reverts commit 213b20a.
)" This reverts commit 213b20a.
* Revert "ADM-831:[frontend]feat: add pipeline is future time check (#1112)" This reverts commit 213b20a. * Revert "ADM-831:[frontend]feat: add pipeline is future time check (#1110)" This reverts commit a138df4. * ADM-831:[frontend]feat: add future time check for metrics step * ADM-831:[frontend]test: add test for pipeline metrics future time check * Revert "ADM-831:[frontend]test: add test for pipeline metrics future time check" This reverts commit a3c12b5. * Revert "ADM-831:[frontend]feat: add future time check for metrics step" This reverts commit 3d3f44d. * ADM-831:[frontend]feat: add future time check for metrics step * ADM-831:[frontend]refactor: adjust import code * ADM-831:[frontend]test: add test for pipeline metrics future time check
Summary
...
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null