Feat: refactore gas charge logic form EVM exit reason #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
reviewed
Aug 8, 2024
aleksuss
reviewed
Aug 13, 2024
aleksuss
reviewed
Aug 13, 2024
mrLSD
added
A-testing
aleksuss
reviewed
Aug 13, 2024
aleksuss
reviewed
Aug 14, 2024
aleksuss
reviewed
Aug 14, 2024
aleksuss
approved these changes
Aug 16, 2024
birchmd
requested changes
Aug 20, 2024
## Description The PR proposes adding some code refactoring to the #935 ## Performance / NEAR gas cost considerations No performance changes. ## Testing A regression test for the `TransactionStatus` has been added.
birchmd
approved these changes
Aug 27, 2024
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Description To be fully compatible with EVM, we should: :arrow_right: Success| Revert :arrow_right: ExitError - Execution errors should charge gas from users :arrow_right: ExitFatal - shouldn't charge user gas :arrow_right: Transactions validation errors should not charge user gas This PR changed the logic for EVM exit reason gas charge for users, which includes EVM execution errors gas charge. Previously transaction just panicked, and user's gas was not charged. #### EVM Related to EVM changes: aurora-is-near/sputnikvm/pull/52 --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
Merged
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com> Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com> Co-authored-by: spilin <LyoshaKR@gmail.com>
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com> Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com> Co-authored-by: spilin <LyoshaKR@gmail.com>
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com> Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com> Co-authored-by: spilin <LyoshaKR@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be fully compatible with EVM, we should:
➡️ Success| Revert
➡️ ExitError - Execution errors should charge gas from users
➡️ ExitFatal - shouldn't charge user gas
➡️ Transactions validation errors should not charge user gas
This PR changed the logic for EVM exit reason gas charge for users, which includes EVM execution errors gas charge. Previously transaction just panicked, and user's gas was not charged.
EVM
Related to EVM changes: aurora-is-near/sputnikvm/pull/52