Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: EVM gas cost optimizations #934

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Jun 28, 2024

Description

Based on SputnikVM EVM optimizations: aurora-is-near/sputnikvm/pull/48

Gas cost

➡️ A lot of tests show gas decreased to: 1-2%
➡️ For some tests gas cost increased, it'is related to: aurora-is-near/sputnikvm/pull/46 as it's requires additional NEAR storage read operation.

@mrLSD mrLSD added A-testing Area: If something has added tests, or changed them. A-evm-compatibility Area: EVM compatibility changes or fixes. labels Jun 28, 2024
@mrLSD mrLSD self-assigned this Jun 28, 2024
@mrLSD mrLSD force-pushed the feat/evm-gas-cost-optimizations branch from cd57a92 to 520195f Compare July 1, 2024 17:50
@mrLSD mrLSD force-pushed the feat/evm-gas-cost-optimizations branch from 520195f to ab48316 Compare July 1, 2024 18:08
engine/src/engine.rs Outdated Show resolved Hide resolved
@aleksuss aleksuss added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit 342d171 Aug 14, 2024
24 checks passed
@aleksuss aleksuss deleted the feat/evm-gas-cost-optimizations branch August 14, 2024 09:22
aleksuss pushed a commit that referenced this pull request Oct 10, 2024
## Description

Based on `SputnikVM` EVM optimizations: aurora-is-near/sputnikvm/pull/48

### Gas cost

➡️  A lot of tests show gas decreased to: `1-2%`
➡️ For some tests gas cost increased, it'is related to:
aurora-is-near/sputnikvm/pull/46 as it's requires additional NEAR
storage read operation.
@aleksuss aleksuss mentioned this pull request Oct 10, 2024
aleksuss added a commit that referenced this pull request Oct 10, 2024
### Additions

- Added support of CANCUN hardfork by [@mrLSD]. ([#926])
- Added support of EIP-3607 by [@mrLSD]. ([#930])
- Removed restrictions from funding XCC sub-accounts by [@birchmd].
([#931])

### Changes

- Made some EVM gas costs optimisations by [@mrLSD]. ([#934])
- Refactored the gas charge logic form EVM exit reasons by [@mrLSD].
([#935])
- Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936])
- Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942])
- Added building of actual version of the `near-sandbox` in the
scheduled CI job by [@aleksuss] ([#950])

### Fixes

- Removed duplicated `test` task in the `README.md` by [@dwiekawki].
([#943])
- Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti].
([#945]) ([#946])
- Fixed exceeded prepaid gas error in the `mirror_erc20_token`
transaction by [@aleksuss] ([#951])
- Modified `hardhat.config.js` to support contract verification by
[@spilin] ([#958])

[#926]: #926
[#930]: #930
[#931]: #931
[#934]: #934
[#935]: #935
[#936]: #936
[#942]: #942
[#943]: #943
[#945]: #945
[#946]: #946
[#950]: #950
[#951]: #951
[#958]: #958

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com>
Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com>
Co-authored-by: spilin <LyoshaKR@gmail.com>
aleksuss added a commit that referenced this pull request Oct 10, 2024
### Additions

- Added support of CANCUN hardfork by [@mrLSD]. ([#926])
- Added support of EIP-3607 by [@mrLSD]. ([#930])
- Removed restrictions from funding XCC sub-accounts by [@birchmd].
([#931])

### Changes

- Made some EVM gas costs optimisations by [@mrLSD]. ([#934])
- Refactored the gas charge logic form EVM exit reasons by [@mrLSD].
([#935])
- Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936])
- Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942])
- Added building of actual version of the `near-sandbox` in the
scheduled CI job by [@aleksuss] ([#950])

### Fixes

- Removed duplicated `test` task in the `README.md` by [@dwiekawki].
([#943])
- Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti].
([#945]) ([#946])
- Fixed exceeded prepaid gas error in the `mirror_erc20_token`
transaction by [@aleksuss] ([#951])
- Modified `hardhat.config.js` to support contract verification by
[@spilin] ([#958])

[#926]: #926
[#930]: #930
[#931]: #931
[#934]: #934
[#935]: #935
[#936]: #936
[#942]: #942
[#943]: #943
[#945]: #945
[#946]: #946
[#950]: #950
[#951]: #951
[#958]: #958

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com>
Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com>
Co-authored-by: spilin <LyoshaKR@gmail.com>
aleksuss added a commit that referenced this pull request Oct 10, 2024
### Additions

- Added support of CANCUN hardfork by [@mrLSD]. ([#926])
- Added support of EIP-3607 by [@mrLSD]. ([#930])
- Removed restrictions from funding XCC sub-accounts by [@birchmd].
([#931])

### Changes

- Made some EVM gas costs optimisations by [@mrLSD]. ([#934])
- Refactored the gas charge logic form EVM exit reasons by [@mrLSD].
([#935])
- Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936])
- Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942])
- Added building of actual version of the `near-sandbox` in the
scheduled CI job by [@aleksuss] ([#950])

### Fixes

- Removed duplicated `test` task in the `README.md` by [@dwiekawki].
([#943])
- Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti].
([#945]) ([#946])
- Fixed exceeded prepaid gas error in the `mirror_erc20_token`
transaction by [@aleksuss] ([#951])
- Modified `hardhat.config.js` to support contract verification by
[@spilin] ([#958])

[#926]: #926
[#930]: #930
[#931]: #931
[#934]: #934
[#935]: #935
[#936]: #936
[#942]: #942
[#943]: #943
[#945]: #945
[#946]: #946
[#950]: #950
[#951]: #951
[#958]: #958

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: dwiekawki <176287097+dwiekawki@users.noreply.github.com>
Co-authored-by: dwiekawki <dwiekawki@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DemoYeti <164791169+DemoYeti@users.noreply.github.com>
Co-authored-by: spilin <LyoshaKR@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-evm-compatibility Area: EVM compatibility changes or fixes. A-testing Area: If something has added tests, or changed them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants