Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: EIP-7610 - non-empty storage create collision and upgrade evm-tests #46

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Jun 18, 2024

Description

EIP-7610 is:

This EIP causes contract creation to throw an error when attempted at an address with pre-existing storage.

New features

➡️ Implemented EIP-7610: Revert creation in case of non-empty storage
➡️ Refactored evm-test to ethereum/tests v13.3
➡️ Generalized cargo crates config fields

Breaking changes

➡️ According to EIP-7610:

This is an execution layer upgrade, and so it requires a hard fork.

➡️ evm-tests backward incompatible with ethereum/tests v13.2

@mrLSD mrLSD self-assigned this Jun 18, 2024
@mrLSD mrLSD added enhancement New feature or request tests release labels Jun 18, 2024
@mrLSD mrLSD requested review from aleksuss and birchmd June 18, 2024 15:07
runtime/src/handler.rs Outdated Show resolved Hide resolved
src/backend/mod.rs Outdated Show resolved Hide resolved
evm-tests/jsontests/Cargo.toml Outdated Show resolved Hide resolved
@mrLSD mrLSD added this to the v0.43.0-aurora milestone Jun 18, 2024
@mrLSD mrLSD merged commit 91ea85d into master Jun 19, 2024
4 checks passed
@mrLSD mrLSD deleted the feat/eth-tests-v13.3 branch June 19, 2024 10:47
github-merge-queue bot pushed a commit to aurora-is-near/aurora-engine that referenced this pull request Aug 14, 2024
## Description

Based on `SputnikVM` EVM optimizations: aurora-is-near/sputnikvm/pull/48

### Gas cost

➡️  A lot of tests show gas decreased to: `1-2%`
➡️ For some tests gas cost increased, it'is related to:
aurora-is-near/sputnikvm/pull/46 as it's requires additional NEAR
storage read operation.
aleksuss pushed a commit to aurora-is-near/aurora-engine that referenced this pull request Oct 10, 2024
## Description

Based on `SputnikVM` EVM optimizations: aurora-is-near/sputnikvm/pull/48

### Gas cost

➡️  A lot of tests show gas decreased to: `1-2%`
➡️ For some tests gas cost increased, it'is related to:
aurora-is-near/sputnikvm/pull/46 as it's requires additional NEAR
storage read operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants