-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require function is used in a way in which dependencies cannot be statically extracted #447
Comments
Thanks for raising @nojaf - can you confirm if this was also a problem in 1.7? |
I checked and it is not a problem with 1.7. |
I'm having the exact same issue after I updated to 1.8.0 |
Same here after updating to 1.8.0. With Angular, it's a warning and not an error though:
|
The same warning Using Angular on @1.8.0:
|
With Angular, I'm getting the same warning on @1.8.0:
|
I actually had to downgrade all the way down to 1.6.0 to get this to work, but with that, lost all typescript types. |
@duro The 1.7.0 works perfectly for me. |
Working with create-react-app Tried changing my import style from
to
but that didn't seem to make a difference. My workaround is to go back to Here is a public project that reproduces: Rabbit |
I was pulling my hair out last week with this, can clarify that is it certainly working on version I suspect the issue may be either the typescript exclusions here or the update to There aren't a huge amount of changes in this version. |
Thanks all, we've identified it as an issue with the latest version of |
Notably Cypress now supports testing components easier https://github.com/bahmutov/cypress-react-unit-test However they're currently catering to react and vue it'd be nice to investigate setting this up for our own components.. Although what we have works fine. Then we can't get update auth0-spa-js until auth0/auth0-spa-js#447 is resolved
Hi all, we've released 1.8.1 which should resolve the issue. Can you try it out and let us know if you run into any issues? |
works! |
1.8.1 works for me. Many thanks! |
Description
When upgrading to 1.8.0 my
create-react-app
build is failing:See https://github.com/nojaf/capital-guardian/runs/636017737
Reproduction
My example project:
https://github.com/nojaf/capital-guardian/blob/master/client/src/App.js
https://github.com/nojaf/capital-guardian/blob/master/client/src/auth0Config.js
Environment
The text was updated successfully, but these errors were encountered: