Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debugging callbacks #17

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Remove debugging callbacks #17

merged 1 commit into from
Sep 25, 2019

Conversation

joshcanhelp
Copy link
Contributor

Waiting on #12

@joshcanhelp joshcanhelp marked this pull request as ready for review September 25, 2019 21:36
@joshcanhelp joshcanhelp requested a review from a team September 25, 2019 21:36
damieng
damieng previously approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW always best to split big package bumps out from other work.

@joshcanhelp
Copy link
Contributor Author

@damieng - Agreed but this came with an npm uninstall so the lock file was altered.

@joshcanhelp joshcanhelp added this to the v0.4.0 milestone Sep 25, 2019
@joshcanhelp joshcanhelp merged commit 01e9664 into auth0:master Sep 25, 2019
@joshcanhelp joshcanhelp deleted the remove-debugging branch September 25, 2019 22:39
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Removed review:small Small review
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng