Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade p-memoize from 4.0.1 to 4.0.2 #286

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Oct 8, 2021

Snyk has created this PR to upgrade p-memoize from 4.0.1 to 4.0.2.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released 21 days ago, on 2021-09-17.
Release notes
Package name: p-memoize from p-memoize GitHub release notes
Commit messages
Package name: p-memoize

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@snyk-bot snyk-bot requested a review from a team as a code owner October 8, 2021 21:36
@adamjmcgrath adamjmcgrath merged commit 47d95ed into master Oct 11, 2021
@adamjmcgrath adamjmcgrath deleted the snyk-upgrade-32bb791058b5d7204a7d6d4ffc141861 branch October 11, 2021 10:08
@JMS-1
Copy link

JMS-1 commented Oct 26, 2021

warning express-openid-connect > p-memoize@4.0.2: 4.0.2 has a bug which causes cache misses. Stay on 4.0.1 or upgrade to 5.0.0.

Is this an issue?

@adamjmcgrath
Copy link
Contributor

@JMS-1 - because the memoized function is awaited (

const issuer = await getIssuer(config.issuerBaseURL);
) - I would say that issue does not affect us. That said, I'll add something to the backlog to update p-memoize so you don't get that warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants