Add telemetry to HTTP requests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Sep 27, 2019
| @@ -4,9 +4,18 @@ const url = require('url'); | |||
| const urlJoin = require('url-join'); | |||
| const pkg = require('../package.json'); | |||
|
|
|||
| const telemetryHeader = { | |||
| name: 'express-oidc', | |||
There was a problem hiding this comment.
Shortened the name a bit but still recognizable.
joshcanhelp
commented
Sep 27, 2019
| custom.setHttpOptionsDefaults({ | ||
| headers: { | ||
| 'User-Agent': `${pkg.name}/${pkg.version} (${pkg.homepage})` | ||
| 'User-Agent': `${pkg.name}/${pkg.version}`, |
There was a problem hiding this comment.
Is this a good user agent? I removed the homepage, seems like unnecessary data.
There was a problem hiding this comment.
@joshcanhelp Do you care about Node version or possibly the OS?
If not, package name and version is probably enough.
There was a problem hiding this comment.
Node version is sent in the env object. We don't parse the user agent (at this point) for telemetry.
joshcanhelp
commented
Sep 27, 2019
| before(async function() { | ||
| client = await getClient(config); | ||
|
|
||
| nock('https://flosser.auth0.com') |
There was a problem hiding this comment.
Nock was the best way I could think of/find for getting the options being used. They are not (understandably) exposed outside of the library.
stevehobbsdev
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a telemetry header to HTTP requests.
Testing
Checklist