DXCDT-337: Add support for segment log stream #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sergiught
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Hey @jeff-auth0 👋🏻 Thanks a lot for the contribution! I went ahead and helped out a little to get this in the right place.
Summary:
- The sink field for segment log stream is actually
segmentWriteKeyso renamed it to that. - Added generated accessors through
make generatecommand. - Added test recordings
sergiught
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This change adds a log stream type and sink for Segment.
📚 References
Required in:
auth0/terraform-provider-auth0#437
🔬 Testing
NOTE: I wrote the tests but was unable to run the test locally. Can you please run to make sure it works?
📝 Checklist