Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for segment log stream #437

Merged
merged 4 commits into from
Jan 27, 2023
Merged

feature: Add support for segment log stream #437

merged 4 commits into from
Jan 27, 2023

Conversation

jeff-auth0
Copy link
Contributor

@jeff-auth0 jeff-auth0 commented Jan 24, 2023

🔧 Changes

This change adds a log stream type and sink for Segment.

📚 References

Dependency changes:

auth0/go-auth0#151

Feature request:

#436

🔬 Testing

NOTE: I wrote the tests but was unable to run the test locally. Can you please run to make sure it works?

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Base: 87.09% // Head: 87.11% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9e98d36) compared to base (c4d6f6a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   87.09%   87.11%   +0.02%     
==========================================
  Files          42       42              
  Lines        9173     9192      +19     
==========================================
+ Hits         7989     8008      +19     
  Misses        910      910              
  Partials      274      274              
Impacted Files Coverage Δ
internal/provider/resource_auth0_log_stream.go 94.95% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jeff-auth0 👍🏻

@sergiught sergiught merged commit ac1ab8e into auth0:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants