Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override annotation on createJSModules method #70

Merged
merged 4 commits into from
Aug 13, 2017

Conversation

lukewlms
Copy link
Contributor

@lukewlms lukewlms commented Aug 2, 2017

React Native v0.47.0 removes the createJSModules call, so this @OverRide now breaks the build.

:react-native-code-push:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/Luke/Projects/ClientPOC/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java:305: error: method does not override or implement a method from a supertype
    @Override
    ^

Confirmed this change fixes the build. See RN Breaking Changes in the v0.47.0 release: https://github.com/facebook/react-native/releases/tag/v0.47.0

See also identical change e.g. in react-native-code-push: microsoft/react-native-code-push@dff9f47

React Native v0.47.0 removes the createJSModules call, so this @OverRide now breaks the build.

```
:react-native-code-push:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/Luke/Projects/ClientPOC/node_modules/react-native-code-push/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java:305: error: method does not override or implement a method from a supertype
    @OverRide
    ^
```

Confirmed this change fixes the build.  See RN Breaking Changes in the v0.47.0 release: https://github.com/facebook/react-native/releases/tag/v0.47.0
@hzalaz
Copy link
Member

hzalaz commented Aug 2, 2017

@lukecwilliams is this backwards compatible with those not in the bleeding edge of RN?

@lukewlms lukewlms changed the title Urgent: Remove breaking createJSModules call Urgent: Remove breaking createJSModules override Aug 2, 2017
@lukewlms
Copy link
Contributor Author

lukewlms commented Aug 2, 2017

I'm not 100% sure, though CodePush says their latest version is only compatible with RN 0.47.0 and the pull request there said it's breaking, so I think the next version of react-native-auth0 would only be compatible with 0.47.0.

Side note - would you mind publishing new releases as Releases instead of Tags? We and probably others are using tools that only track Releases! Thanks a lot.

@hzalaz
Copy link
Member

hzalaz commented Aug 2, 2017

@lukecwilliams try removing the override annotation. That will probably make this backwards compatible otherwise we need to think how to handle this (won't be the last since RN introduces breaking changes all the time)

lukewlms pushed a commit to lukewlms/react-native-lock that referenced this pull request Aug 2, 2017
Parallel change to that required in react-native-auth0: auth0/react-native-auth0#70
Luke Williams added 3 commits August 2, 2017 16:15
Just removing @OverRide works with 0.47.0 and should also be fine with previous versions, as the @OverRide keyword is not required in Java.
@lukewlms
Copy link
Contributor Author

lukewlms commented Aug 2, 2017

Removing @OverRide works for 0.47.0 and yes, should work in earlier versions. Good idea.

@hzalaz hzalaz changed the title Urgent: Remove breaking createJSModules override Remove override annotation on createJSModules method Aug 13, 2017
@hzalaz hzalaz merged commit cfe16c3 into auth0:master Aug 13, 2017
@hzalaz hzalaz added this to the v1.0.4 milestone Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants