Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override annotation on createJSModules method #70

Merged
merged 4 commits into from
Aug 13, 2017
Merged

Remove override annotation on createJSModules method #70

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
186a00d
Urgent: Remove breaking createJSModules call
Aug 2, 2017
94cd47a
Re-add createJSModules with @Override removed
Aug 2, 2017
7cb57fb
Update A0Auth0Package.java
Aug 2, 2017
b53b528
Update A0Auth0Package.java
Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/auth0/react/A0Auth0Package.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
return Arrays.<NativeModule>asList(new A0Auth0Module(reactContext));
}

@Override
// Required @Override for RN v0.46.x and earlier
public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}
Expand All @@ -25,4 +25,4 @@ public List<Class<? extends JavaScriptModule>> createJSModules() {
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Collections.emptyList();
}
}
}