Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop Fix Patch 3 #1437

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Rubocop Fix Patch 3 #1437

merged 6 commits into from
Dec 2, 2021

Conversation

victorhuangwq
Copy link
Contributor

This is part of an effort to enforce style in the codebase

Description

I focused on a few smaller files

Motivation and Context

We need to do this so that we can enable rubocop on our codebase

How Has This Been Tested?

  • Ran rubocop
  • Ran rails s
  • Submitted a file, graded the file, used bulk release, tweak a students grades.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@oliverli oliverli self-requested a review December 2, 2021 22:59
Copy link
Contributor

@oliverli oliverli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@victorhuangwq victorhuangwq merged commit 2b2164e into master Dec 2, 2021
@victorhuangwq victorhuangwq deleted the rubocop-patch-3 branch December 2, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants