Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue of Bulk Release Name Change #1518

Merged
merged 1 commit into from
May 12, 2022
Merged

Fixes Issue of Bulk Release Name Change #1518

merged 1 commit into from
May 12, 2022

Conversation

victorhuangwq
Copy link
Contributor

@victorhuangwq victorhuangwq commented May 12, 2022 •
edited
Loading

Variable name change as part of #1437 was not propagated properly. This PR fixes that.

Description

Changes bulkRelease to bulk_release at the relevant pages

Motivation and Context

Bug report

How Has This Been Tested?

Visit:
http://localhost:3000/courses/AutoPopulated/manage
and click release all grades

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

xinyis991105
xinyis991105 approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@xinyis991105 xinyis991105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Management page. Works fine. LGTM!

@victorhuangwq victorhuangwq merged commit 6934805 into master May 12, 2022
@victorhuangwq victorhuangwq deleted the fix-bulk-release branch May 12, 2022 16:25
cg2v pushed a commit to cg2v/Autolab that referenced this pull request May 12, 2022
@victorhuangwq @cg2v
Update namechange of bulk_release (autolab#1518)
f995fdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyis991105 xinyis991105 xinyis991105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorhuangwq @xinyis991105