Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #1526

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Fix typos #1526

merged 5 commits into from
Jun 21, 2022

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented May 16, 2022 •
edited
Loading

Description

  • Fix general text typos
  • Remove duplicate CSS properties (i.e. same property defined twice for the same selector)
  • Fix some HTML tags

Motivation and Context

General code clean-up based on RubyMine's problem analysis.

How Has This Been Tested?

  • General text typos: N/A
  • Duplicate CSS properties: N/A (the later definition takes precedence, and this PR deletes the earlier definition)
  • HTML tags: N/A (Simple syntactical changes like </td> --> </th>)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@damianhxy damianhxy changed the title Initial commit Code Clean-up May 16, 2022
@damianhxy damianhxy changed the title Code Clean-up Fix typos May 19, 2022
@damianhxy
Restore </li>
e704b09 
edit: although tag technically creates a closed tag by default, leaving in the </li> doesn't seem to hurt. However we should actually use content_tag instead

show: equal number of opening and closing tags, presumably it matches something
@damianhxy damianhxy marked this pull request as ready for review June 20, 2022 16:26
20wildmanj
20wildmanj approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good! Ran and checked to make sure style was still the same as well, no changes to report. LGTM!

@damianhxy damianhxy merged commit 89a762b into master Jun 21, 2022
@damianhxy damianhxy deleted the code-cleanup branch June 21, 2022 02:40
@damianhxy damianhxy mentioned this pull request Jun 21, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20wildmanj 20wildmanj 20wildmanj approved these changes

Assignees
No one assigned
Labels
Priority: Low Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damianhxy @20wildmanj