Add ok/error logic to the decorator #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For record_error_if and record_success_if
flenter
force-pushed
the
resolve_45_add_ok_error_logic
branch
from
932442a to
b5b82f8
Compare
This is done by using the "follow_imports=skip" option for opentelemetry.attributes
actualwitch
approved these changes
Aug 28, 2023
.github/workflows/main.yml
Outdated
| cache: poetry | ||
| - name: Install dependencies | ||
| run: poetry install --no-interaction --no-root --with dev | ||
| run: poetry install --no-interaction --no-root --with dev --with examples |
Contributor
There was a problem hiding this comment.
--with supports comma separated syntax too 🙃
Suggested change
| run: poetry install --no-interaction --no-root --with dev --with examples | |
| run: poetry install --no-interaction --no-root --with dev,examples |
Contributor
There was a problem hiding this comment.
nice! i wanted to add these as well
Contributor
There was a problem hiding this comment.
since we are exposing types correctly now, i think it would be fair to also add the "Typing :: Typed" classifier 🧐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also switch to mypy (instead of pyright). There's an issue with pyright and the return value for coroutines (microsoft/pyright#5745) which caused problems for our library and I also ran into issues when overloading the decorator and pyright not complaining about certain overloads which would never be used because other overloads were more generic/broadly defined).
Anyway the real meat of the matter is the addition of:
record_error_ifrecord_ok_ifWhich allows the user of the lib to make certain exceptions not show up as errors and certain normal responses to register as errors.
Resolves #45