-
Notifications
You must be signed in to change notification settings - Fork 8
Add ok/error logic to the decorator #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
38711e6
Base implementation
flenter a17255d
Update pyright
flenter abbe50c
Update typings & initial test
flenter 4723824
Format code
flenter 6cca5a4
Apply record_error_if logic to sync functions
flenter 0f643c7
Fix build
flenter a38f15e
Switch to mypy
flenter e48b11d
Enable incomplete feature Unpack
flenter d13cbde
Install examples
flenter fe8205a
Add py.typed to src
flenter 2a07de8
use --all-extras
flenter 685fa1d
Use with dev/examples
flenter f3cddd2
Add mypy config to pyproject
flenter b5b82f8
add fix for opentelemetry
flenter c4e8d33
Fix build with pypy (and python 3.10)
flenter 407ebac
Merge remote-tracking branch 'origin/main' into resolve_45_add_ok_err…
flenter 7d7ad1c
Update changelog
flenter b732db5
Add examples to fastapi-example.py
flenter 575f13d
Feedback on pr
flenter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[mypy] | ||
plugins = | ||
mypy_django_plugin.main | ||
|
||
[mypy.plugins.django-stubs] | ||
django_settings_module = "django_example.settings" |
Large diffs are not rendered by default.
Oops, something went wrong.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since we are exposing types correctly now, i think it would be fair to also add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--with
supports comma separated syntax too 🙃