Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] clone test of dummy estimator #1129

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

franchuterivera
Copy link
Contributor

Moves the dummy estimator clone check to the correct place

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1129 (bfd671f) into development (802c337) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1129      +/-   ##
===============================================
- Coverage        85.85%   85.83%   -0.02%     
===============================================
  Files              137      137              
  Lines            10623    10625       +2     
===============================================
  Hits              9120     9120              
- Misses            1503     1505       +2     
Impacted Files Coverage Δ
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
autosklearn/ensemble_builder.py 76.65% <0.00%> (-0.41%) ⬇️
autosklearn/automl.py 84.75% <0.00%> (-0.10%) ⬇️
...mponents/feature_preprocessing/nystroem_sampler.py 91.17% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802c337...bfd671f. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks great, but there's a pre-commit error.

@mfeurer mfeurer merged commit 0982410 into automl:development Apr 21, 2021
mfeurer pushed a commit that referenced this pull request May 4, 2021
* [FIX] clone test of dummy estimator (#1129)

* [FIX] clone test of dummy estimator

* [FIX] flake8

* [Fix] stale only-labels

* [Fix] Mark as stale if any of the provided labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants