Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] stale only-labels #1134

Merged
merged 3 commits into from
May 4, 2021
Merged

Conversation

franchuterivera
Copy link
Contributor

Only labels was misunderstood on my part:

# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)

All the labels have to be present. There is support to except labels here.

This works as showed here:

franchuterivera and others added 2 commits April 21, 2021 22:59
* [FIX] clone test of dummy estimator

* [FIX] flake8
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1134 (d50ed09) into development (0982410) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1134      +/-   ##
===============================================
- Coverage        85.83%   85.77%   -0.06%     
===============================================
  Files              137      137              
  Lines            10625    10625              
===============================================
- Hits              9120     9114       -6     
- Misses            1505     1511       +6     
Impacted Files Coverage Δ
...ine/components/feature_preprocessing/kernel_pca.py 94.73% <0.00%> (-1.76%) ⬇️
autosklearn/util/backend.py 75.08% <0.00%> (-1.43%) ⬇️
autosklearn/ensemble_builder.py 76.65% <0.00%> (-0.41%) ⬇️
...ine/components/classification/gradient_boosting.py 92.17% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0982410...d50ed09. Read the comment docs.

@mfeurer
Copy link
Contributor

mfeurer commented Apr 27, 2021

What would happen if an issue is labeled bug and Feedback-Required?

@franchuterivera
Copy link
Contributor Author

Bug takes priority, for example, if one looks into R-studio issues, in particular, 5621 one can see that it has been idle since 2019 but it has the label documentation so it will not be closed.

@mfeurer mfeurer changed the base branch from development to master May 4, 2021 19:28
@mfeurer mfeurer merged commit 0690a4d into automl:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants