Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial subspace-erasure-coding implementation #1214

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Mar 3, 2023

This introduces new crate that covers first 3/4 items from #1163. The last one will be added separately later, I think I'll need to unity some types to make it ergonomic first.

The code is trivial, but the challenge was that dependencies didn't install (yanked crates), then didn't compile, then it didn't support no_std and it took a bit of time to resolve all of those.

Draft PR for now since it is not yet very useful without other pieces for v2.3 consensus and can wait for some of the upcoming PRs to land in rust-kzg (there is still one I'll be submitting soon, waiting for another to be merged first). Hopefully it'll all land into main, but at very least somewhere upstream rather than our fork (maintainers were quick to merge things, so shouldn't be long).

Code contributor checklist:

@dariolina
Copy link
Contributor

Looks OK from my side!

@nazar-pc nazar-pc force-pushed the subspace-erasure-coding branch from 9671616 to 7b59e0f Compare March 14, 2023 16:13
@nazar-pc nazar-pc marked this pull request as ready for review March 14, 2023 16:15
@nazar-pc
Copy link
Member Author

Rebased against main with dependencies pointing to upstream since all of the necessary changes are there. No code changes.

@nazar-pc nazar-pc requested a review from i1i1 March 14, 2023 16:16
@nazar-pc nazar-pc requested review from liuchengxu and shamil-gadelshin and removed request for liuchengxu March 15, 2023 11:39
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a small comment for tests.

@nazar-pc nazar-pc merged commit 47f6511 into main Mar 20, 2023
@nazar-pc nazar-pc deleted the subspace-erasure-coding branch March 20, 2023 01:52
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Mar 20, 2023
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Mar 20, 2023
@nazar-pc nazar-pc mentioned this pull request Mar 22, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants