New Scalar #1285
Merged
New Scalar #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity for its internal field
…e replaced with a different implementation)
nazar-pc
requested review from
i1i1,
liuchengxu,
rg3l3dr and
vedhavyas
as code owners
i1i1
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1281 and #1214 and is a step towards #1282.
We had
Kzgthat worked with bytes (converting to scalars internally) andsubspace-erasure-codingworking with scalars (converting to a completely different type internally due to scalar corresponding to a different underlying crypto library).Since in archiving we'll be dealing with both erasure coding and commitments, it makes sense to use the same scalar for both purposes.
This PR renames existing scalar to
ScalarLegacyand introduces newScalar, which shares some similarities, but has stricter and richer API. With this new scalar type bothKzgandsubspace-erasure-codingare refactored to use it with some efficiency gains in the process.Reviewing commits individually should make the most sense.
There is a bit of isolated and carefully written
unsafethat allows us to avoid large re-allocations in performance-sensitive code paths.Code contributor checklist: