Fix stack overflow during piece decoding #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
vedhavyas,
liuchengxu,
shamil-gadelshin,
i1i1 and
rahulksnv
i1i1
previously approved these changes
Mar 26, 2023
nazar-pc
force-pushed
the
fix-stack-overflow-piece-decoding
branch
from
7ec9edc to
c802467
Compare
i1i1
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@i1i1's suggestion in #1287 lead to paritytech/parity-scale-codec#419, which is in fact long standing rust-lang/rust#53827. Workaround with manual implementation is applied to avoid stack overflow for now.
Code contributor checklist: