Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing setup.py for jetson #1135

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

DocGarbanzo
Copy link
Contributor

Remove albumentations from jetson setup and move pyyaml into the required section, so it also installs on RPi. Also bump version.

@DocGarbanzo DocGarbanzo requested a review from Ezward July 1, 2023 13:04
@Ezward
Copy link
Contributor

Ezward commented Jul 2, 2023

Should we just replace the two augmentations with our own code? One is guassian blur and we already have that in

class ImgGaussianBlur:
and the other is a randomized brightness/contrast that we could easily implement.

I added an issue for this; #1136

@Ezward
Copy link
Contributor

Ezward commented Jul 2, 2023

However, for now this is a good enough fix. Thanks @DocGarbanzo

…on nano, only on xavier, etc where we have JP 5.0.X.
@DocGarbanzo
Copy link
Contributor Author

Should we just replace the two augmentations with our own code? One is guassian blur and we already have that in

class ImgGaussianBlur:

and the other is a randomized brightness/contrast that we could easily implement.

I added an issue for this; #1136

Yes, I was thinking the exact same thing. I want to google around a bit if there are other augmentations that might be useful for use, but for blur / brightness we can just use the one you already created.

@DocGarbanzo DocGarbanzo merged commit 9f91ad1 into autorope:main Jul 5, 2023
@DocGarbanzo DocGarbanzo deleted the fix_setup branch April 4, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants