-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor #1133
feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor #1133
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
========================================
- Coverage 8.97% 8.93% -0.04%
========================================
Files 1027 1027
Lines 64430 64713 +283
Branches 14134 14134
========================================
Hits 5784 5784
- Misses 53686 53969 +283
Partials 4960 4960
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and I could monitor the desired and current steering tire angle using plotjuggler
.
b7a3584
to
749c1c6
Compare
…ing tire angle in driving monitor Signed-off-by: Berkay <berkay@leodrive.ai>
Signed-off-by: Berkay <berkay@leodrive.ai>
749c1c6
to
d9b2c0f
Compare
Signed-off-by: Berkay <berkay@leodrive.ai>
…ing tire angle in driving monitor (tier4#1133) * feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update readme Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update lpf for steering monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix Co-authored-by: Berkay <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ing tire angle in driving monitor (tier4#1133) * feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update readme Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update lpf for steering monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix Co-authored-by: Berkay <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ing tire angle in driving monitor (tier4#1133) * feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update readme Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update lpf for steering monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix Co-authored-by: Berkay <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ing tire angle in driving monitor (tier4#1133) * feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update readme Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix * update lpf for steering monitor Signed-off-by: Berkay <berkay@leodrive.ai> * ci(pre-commit): autofix Co-authored-by: Berkay <berkay@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…avoidance feat(avoidance): consider objects on shift side lane (autowarefoundation#6252)
make expansion optional Signed-off-by: beyza <bnk@leodrive.ai>
Signed-off-by: Berkay berkay@leodrive.ai
Description
Issue: #567
While testing controller, we could not monitor the desired steering tire angle in current
control_performance_analysis
package. Current and desired steering tire angle information is published with this PR incontrol_performance_analysis
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.