Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor #1133

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Jun 20, 2022

Signed-off-by: Berkay berkay@leodrive.ai

Description

Issue: #567

While testing controller, we could not monitor the desired steering tire angle in current control_performance_analysis package. Current and desired steering tire angle information is published with this PR in control_performance_analysis.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jun 20, 2022
@brkay54 brkay54 self-assigned this Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1133 (2b0e07a) into main (1110bc4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1133      +/-   ##
========================================
- Coverage   8.97%   8.93%   -0.04%     
========================================
  Files       1027    1027              
  Lines      64430   64713     +283     
  Branches   14134   14134              
========================================
  Hits        5784    5784              
- Misses     53686   53969     +283     
  Partials    4960    4960              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 8.97% <0.00%> (ø) Carriedforward from d6217fc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...analysis/src/control_performance_analysis_core.cpp 0.00% <0.00%> (ø)
...analysis/src/control_performance_analysis_node.cpp 0.00% <0.00%> (ø)
...ce_analysis/control_performance_analysis_utils.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1388dfd...2b0e07a. Read the comment docs.

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I could monitor the desired and current steering tire angle using plotjuggler.

@brkay54 brkay54 force-pushed the monitor-steering-control-performance-analysis branch from b7a3584 to 749c1c6 Compare June 21, 2022 11:11
Berkay and others added 4 commits June 21, 2022 14:27
…ing tire angle in driving monitor

Signed-off-by: Berkay <berkay@leodrive.ai>
Signed-off-by: Berkay <berkay@leodrive.ai>
@brkay54 brkay54 force-pushed the monitor-steering-control-performance-analysis branch from 749c1c6 to d9b2c0f Compare June 21, 2022 11:29
Berkay and others added 2 commits June 21, 2022 14:46
Signed-off-by: Berkay <berkay@leodrive.ai>
@brkay54 brkay54 enabled auto-merge (squash) June 21, 2022 11:48
@brkay54 brkay54 merged commit a075e60 into autowarefoundation:main Jun 21, 2022
@brkay54 brkay54 deleted the monitor-steering-control-performance-analysis branch July 19, 2022 15:20
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ing tire angle in driving monitor (tier4#1133)

* feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update lpf for steering monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ing tire angle in driving monitor (tier4#1133)

* feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update lpf for steering monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ing tire angle in driving monitor (tier4#1133)

* feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update lpf for steering monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ing tire angle in driving monitor (tier4#1133)

* feat(control_performance_analysis): monitor desired and current steering tire angle in driving monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update readme

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

* update lpf for steering monitor

Signed-off-by: Berkay <berkay@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: Berkay <berkay@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Feb 15, 2024
…avoidance

feat(avoidance): consider objects on shift side lane (autowarefoundation#6252)
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
make expansion optional

Signed-off-by: beyza <bnk@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants