Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multi_object_tracker): fix measurement dimension #1156

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix(multi_object_tracker): fix measurement dimension #1156

merged 1 commit into from
Jun 23, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 22, 2022 •
edited
Loading

Signed-off-by: yutaka purewater0901@gmail.com

Description

Fix Measurement dimension when measurement velocity is invalid

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901
fix(multi_object_tracker): fix measurement dimension
9088b19 
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 requested a review from yukkysaito June 22, 2022 13:08
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1156 (9088b19) into main (86c3fad) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1156   +/-   ##
=====================================
  Coverage   9.08%   9.08%           
=====================================
  Files       1034    1034           
  Lines      70474   70474           
  Branches   14692   14692           
=====================================
  Hits        6403    6403           
  Misses     58573   58573           
  Partials    5498    5498
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.06% <0.00%> (ø) Carriedforward from 86c3fad

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <0.00%> (ø)
...acker/src/tracker/model/normal_vehicle_tracker.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c3fad...9088b19. Read the comment docs.

@purewater0901
Copy link
Contributor Author

I'll merge this PR once other users confirm that the problem is resolved

@purewater0901 purewater0901 merged commit cf3ad0c into autowarefoundation:main Jun 23, 2022
@purewater0901 purewater0901 deleted the fix/measurement-dimension branch June 23, 2022 02:14
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 24, 2022
Merged
yukkysaito added a commit to yukkysaito/autoware.universe that referenced this pull request Jun 29, 2022
@YoheiMishina @mitsudome-r
@aohsato @nnmm @nik-tier4 @TakaHoribe @taikitanaka3 @yukkysaito @wep21 @kenji-miyake @kmiya @tkimura4 @KeisukeShima @h-ohta @yukke42 @tier4-autoware-private-bot @satoshi-ota @1222-takeshi
feat: add roi cluster fusion package (autowarefoundation#116)
a575a9e 
* release v0.4.0

* Modify to use projection matrix with undistorted 2D result (autowarefoundation#722)

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118)

compiles succesfully.
Getting some undefined reference error while launching the node.

* Port euclidean cluster (autowarefoundation#120)

* porting CmakeLists.txt and package.xml in progress

* ported CMakeLists.txt and package.xml to ROS2

* Ported euclidean_cluster from ROS1 to ROS2

* deleted unnecesary files

* fixed transient_local

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* hotfix roi_cluster_fusion (autowarefoundation#239)

* Fix perception launches (autowarefoundation#240)

* fix roi_cluster_fusion launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

* add comment on launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>

* Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321)

* restore v0.5.0

* Feature/fusion debug (autowarefoundation#1051)

* add debuger

* change param

* add publisher

* Compatible with opencv4 (autowarefoundation#1156)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* refactor for ros2 style

* fix code

* to hpp

* fix code

* uncursify

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix transform (autowarefoundation#420)

* Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix canTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix test

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo in perception module (autowarefoundation#440)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625)

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Use set_remap for if tag (autowarefoundation#1800)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply format (autowarefoundation#1999)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix cpplint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Detection by tracker (autowarefoundation#1910)

* initial commit

* backup

* apply format

* cosmetic change

* implement divided under segmenterd clusters

* cosmetic change

* bug fix

* bug fix

* bug fix

* modify launch

* add debug and bug fix

* bug fix

* bug fix

* add no found tracked object

* modify parameters and cmake

* bug fix

* remove debug info

* add readme

* modify clustering launch

* run pre-commit

* cosmetic change

* cosmetic change

* cosmetic change

* apply markdownlint

* modify launch

* modify for cpplint

* modify qos

* change int to size_T

* bug fix

* change perception qos

* Update perception/object_recognition/detection/detection_by_tracker/package.xml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* cosmetic change

* cosmetic change

* fix launch

* Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* modify header include order

* change include order

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* change to std::optional

* cosmetic change

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* bug fix

* modify readme

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* sync rc rc/v0.23.0 (autowarefoundation#2219)

* Fix qos in roi cluster fusion (autowarefoundation#2218)

* fix confidence (autowarefoundation#2220)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port roi cluster fusion (autowarefoundation#536)

* remove COLCON_IGNORE

* use DetectedObjectsWithFeature

* fix topic type

* update overwrite condition

* add README of roi_cluster_fusion (autowarefoundation#653)

* add README of roi_cluster_fusion

* fix typo

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add image

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
purewater0901 referenced this pull request in tier4/autoware.universe Jun 30, 2022
@purewater0901
fix(multi_object_tracker): fix measurement dimension (#1156)
c014673 
Signed-off-by: yutaka <purewater0901@gmail.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 7, 2022
@purewater0901 @takayuki5168
fix(multi_object_tracker): fix measurement dimension (#1156)
b2d2e4f 
Signed-off-by: yutaka <purewater0901@gmail.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 8, 2022
@purewater0901 @takayuki5168
fix(multi_object_tracker): fix measurement dimension (#1156)
3992599 
Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@purewater0901 @boyali
fix(multi_object_tracker): fix measurement dimension (tier4#1156)
fbf022e 
Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@purewater0901 @boyali
fix(multi_object_tracker): fix measurement dimension (tier4#1156)
02be27a 
Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@purewater0901 @boyali
fix(multi_object_tracker): fix measurement dimension (tier4#1156)
37bb6cc 
Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@purewater0901 @boyali
fix(multi_object_tracker): fix measurement dimension (tier4#1156)
047a175 
Signed-off-by: yutaka <purewater0901@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Mar 7, 2024
@TomohitoAndo
feat(behavior_velocity_traffic_light): ensure stopping if a signal, o…
c5a5436 
…nce received, is not received again (autowarefoundation#6468) (autowarefoundation#1156)

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."



* add comments for clarity



* fix comments for clarity



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request May 23, 2024
@TomohitoAndo
feat(behavior_velocity_traffic_light): ensure stopping if a signal, o…
955c353 
…nce received, is not received again (autowarefoundation#6468) (autowarefoundation#1156)

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."



* add comments for clarity



* fix comments for clarity



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
@soblin
feat(goal_planner): dense goal candidate sampling in BusStopArea (aut…
8a4a3e9 
…owarefoundation#1156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purewater0901 @yukkysaito