Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(behavior_path_planner): change logger throttle #1157

Merged
merged 7 commits into from
Jun 23, 2022
Merged

chore(behavior_path_planner): change logger throttle #1157

merged 7 commits into from
Jun 23, 2022

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Jun 22, 2022

Description

Currently, behavior_path_planner puts too much error log.
So I've changed the logger throttle.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

shmpwk added 3 commits June 22, 2022 21:59
@shmpwk
chore(behavior_path_planner): change logger throttle
f3ebc07 
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk
chore(behavior_path_planner): change error throttle
5e487b9 
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk
chore(behavior_path_planner): from get_logger to getLogger
55bd202 
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk shmpwk added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2022
@shmpwk shmpwk requested review from tkimura4 and taikitanaka3 June 22, 2022 13:19
@shmpwk shmpwk marked this pull request as draft June 22, 2022 13:34
@shmpwk
chore(behavior_path_planner): fix bug
6c4d037 
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk shmpwk force-pushed the chore/update_log_verbose branch from 5dddb44 to 6c4d037 Compare June 23, 2022 02:10
@shmpwk shmpwk marked this pull request as ready for review June 23, 2022 02:11
@shmpwk shmpwk mentioned this pull request Jun 23, 2022
Closed
7 tasks
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #1157 (9a9574c) into main (a8e2308) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1157      +/-   ##
========================================
- Coverage   9.12%   9.08%   -0.04%     
========================================
  Files       1034    1034              
  Lines      70634   70923     +289     
  Branches   14757   14984     +227     
========================================
+ Hits        6444    6445       +1     
+ Misses     58903   58896       -7     
- Partials    5287    5582     +295
Flag Coverage Δ *Carryforward flag
differential 0.93% <0.00%> (?)
total 9.11% <0.00%> (+<0.01%) ⬆️ Carriedforward from 936b714

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.43% <0.00%> (+0.19%) ⬆️
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)
map/lanelet2_extension/lib/query.cpp 9.52% <0.00%> (ø)
map/lanelet2_extension/lib/utilities.cpp 8.89% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 34.35% <0.00%> (ø)
map/lanelet2_extension/lib/visualization.cpp 0.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed66cb...9a9574c. Read the comment docs.

tkimura4
tkimura4 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge (squash) June 23, 2022 10:53
@shmpwk shmpwk merged commit 918b91f into autowarefoundation:main Jun 23, 2022
@shmpwk shmpwk deleted the chore/update_log_verbose branch June 23, 2022 11:22
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 24, 2022
Merged
yukkysaito pushed a commit to yukkysaito/autoware.universe that referenced this pull request Jun 29, 2022
@tkimura4 @wep21
@mitsudome-r @kenji-miyake @kmiya @h-ohta @1222-takeshi @taikitanaka3
feat: add topic_state_monitor package (autowarefoundation#15)
6dd12d6 
* Ros2 v0.8.0 topic state monitor (autowarefoundation#283)

* Add node_name_suffix to topic_state_monitor.launch (autowarefoundation#1157) (autowarefoundation#370)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix launch file (autowarefoundation#411)

* add transient local option to topic state monitor (autowarefoundation#410)

* add transient local option to topic state monitor

* sort parameters

* sort parameter

* [topic_state_monitor]: Add best effort option (autowarefoundation#430)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* add use_sim-time option (autowarefoundation#454)

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* change to composable node (autowarefoundation#1233)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint errors (autowarefoundation#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix variable names

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use integrated generic subscription (autowarefoundation#1342)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* suppress warnings for declare parameters (autowarefoundation#1724)

* fix for lanelet2_extension

* fix for traffic light ssd fine detector

* fix for topic_state_monitor

* fix for dummy diag publisher

* fix for remote cmd converter

* fix for vehicle_info_util

* fix for multi object tracker

* fix for freespace planner

* fix for autoware_error_monitor

* add Werror for multi object tracker

* fix for multi object tracker

* add Werror for liraffic light ssd fine detector

* add Werror for topic state monitor

* add Werror

* add Werror

* add Werror

* add Werror

* fix style

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532)

* [topic_state_monitor]add readme (autowarefoundation#565)

* add readme

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update system/topic_state_monitor/Readme.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@shmpwk @pre-commit-ci
@tkimura4 @boyali
chore(behavior_path_planner): change logger throttle (tier4#1157)
491888e 
* chore(behavior_path_planner): change logger throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): change error throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): from get_logger to getLogger

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): fix bug

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@shmpwk @pre-commit-ci
@tkimura4 @boyali
chore(behavior_path_planner): change logger throttle (tier4#1157)
fecb11f 
* chore(behavior_path_planner): change logger throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): change error throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): from get_logger to getLogger

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): fix bug

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@shmpwk @pre-commit-ci
@tkimura4 @boyali
chore(behavior_path_planner): change logger throttle (tier4#1157)
d7ae1d3 
* chore(behavior_path_planner): change logger throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): change error throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): from get_logger to getLogger

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): fix bug

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@shmpwk @pre-commit-ci
@tkimura4 @boyali
chore(behavior_path_planner): change logger throttle (tier4#1157)
4652cd8 
* chore(behavior_path_planner): change logger throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): change error throttle

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): from get_logger to getLogger

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* chore(behavior_path_planner): fix bug

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
TomohitoAndo added a commit to TomohitoAndo/autoware.universe that referenced this pull request Mar 21, 2024
@soblin @mkuri @TomohitoAndo
feat(hazard_lights_selector): add hazard_lights_selector (autowarefou…
f173fad 
…ndation#1157)

* feat(hazard_lights_selector): turn on hazard lights from mrm comfortable stop operator (autowarefoundation#323)

* chore(hazard_lights_selector): add the hazard_lights_selector package

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(hazard_lights_selector): implement a header file

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(hazard_lights_selector): implement the hazard_lights_selector package

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(hazard_lights_selector): remove a current hazard lights command state

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* refacotr(hazard_lights_selector): remove extra lines

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat(mrm_comfortable_stop_operator): add hazard lights publisher

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(hazard_lights_selector): add a maintainer

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* style: pre-commit fixes

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp>

* migrate to latest

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com>
Co-authored-by: Tomohito Ando <tomohito.ando@tier4.jp>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
@mkquda
feat(lane_change): add lane change parameter (autowarefoundation#1157)
4288f79 
add parameter to enable/disable bound check

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkimura4 tkimura4 tkimura4 approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shmpwk @tkimura4