feat(pull_over): support new framework

[satoshi-ota]

Description

⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#237

It is able to build avoidance module on new framework (added in #2919).

Related links

Tests performed

Checkout your branch of autoware_launch to feat/support-new-framework-pull-over.
https://github.com/autowarefoundation/autoware_launch/tree/feat/support-new-framework-pull-over

In addtion, we may have to comment out module names which haven't supported new framework yet in rtc_auto_mode_manager.param.yaml.

/**:
  ros__parameters:
    module_list:
      - "blind_spot"
      - "crosswalk"
      - "detection_area"
      - "intersection"
      - "no_stopping_area"
      - "traffic_light"
      # - "ext_request_lane_change_left"
      # - "ext_request_lane_change_right"
      # - "lane_change_left"
      # - "lane_change_right"
      # - "avoidance_left"
      # - "avoidance_right"
      - "pull_over"
      # - "pull_out"
...

Please set following flag to FALSE, and confirm to pass all build.

autoware.universe/planning/behavior_path_planner/CMakeLists.txt

Line 10 in ad55953

set(COMPILE_WITH_OLD_ARCHITECTURE TRUE)

Launch Psim and check the avoidance module working correctly.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (7f064da) 11.93% compared to head (25c8be5) 11.93%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3005      +/-   ##
==========================================
- Coverage   11.93%   11.93%   -0.01%     
==========================================
  Files        1321     1321              
  Lines       91937    91957      +20     
  Branches    24522    24544      +22     
==========================================
  Hits        10976    10976              
- Misses      69603    69620      +17     
- Partials    11358    11361       +3     

Flag	Coverage Δ		*Carryforward flag
differential	5.58% <0.00%> (?)
total	11.95% <ø> (+0.01%)	⬆️	Carriedforward from 7f064da

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp	0.00% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp	0.00% <0.00%> (ø)
...lanner/scene_module/pull_over/pull_over_module.hpp	0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp	0.14% <0.00%> (-0.01%)	⬇️
...rc/scene_module/lane_change/lane_change_module.cpp	0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp	0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kosuke55]

thank you, LGTM!

checked

• shift pull over
• arc forward pull over
• arc backward pull over
• free space pull over
  with rtc