Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): support new framework #3016

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Mar 7, 2023

Description

⬇️ This must be merged before this PR.
autowarefoundation/autoware_launch#239

Related links

Tests performed

Before perfoming test, please comment out module names which haven't supported new framework yet in rtc_auto_mode_manager.param.yaml. -->

/**:
  ros__parameters:
    module_list:
      - "blind_spot"
      - "crosswalk"
      - "detection_area"
      - "intersection"
      - "no_stopping_area"
      - "traffic_light"
      # - "ext_request_lane_change_left"
      # - "ext_request_lane_change_right"
       - "lane_change_left"
       - "lane_change_right"
      # - "avoidance_left"
      # - "avoidance_right"
      # - "pull_over"
      # - "pull_out"

Please set following flag to FALSE, and confirm to pass all build.

set(COMPILE_WITH_OLD_ARCHITECTURE TRUE)

Launch Psim and check the avoidance module working correctly.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.81 🎉

Comparison is base (c432281) 11.93% compared to head (3a9400d) 12.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
+ Coverage   11.93%   12.74%   +0.81%     
==========================================
  Files        1321     1219     -102     
  Lines       91943    86079    -5864     
  Branches    24525    24533       +8     
==========================================
- Hits        10976    10974       -2     
+ Misses      69609    63745    -5864     
- Partials    11358    11360       +2     
Flag Coverage Δ *Carryforward flag
differential 5.58% <0.00%> (?)
total 12.76% <ø> (+0.82%) ⬆️ Carriedforward from f02aa4c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.14% <0.00%> (-0.01%) ⬇️
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 80.95% <0.00%> (-4.77%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
..._vendor/_deps/tensorrt-src/samples/common/common.h
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-support-new-framework-lane-change branch from 2ad43a7 to 8ab698a Compare March 8, 2023 06:08
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the feat-support-new-framework-lane-change branch from 75f758b to 928956c Compare March 8, 2023 06:52
pre-commit-ci bot and others added 2 commits March 8, 2023 06:53
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
Copy link
Contributor Author

Degradation test results, build with USE_OLD_ARCHITECTURE = TRUE
TIER IV internal link

Degradation test results, build with USE_OLD_ARCHITECTURE = FALSE
TIER IV internal link

@satoshi-ota satoshi-ota merged commit de19018 into autowarefoundation:main Mar 9, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-support-new-framework-lane-change branch March 9, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants