fix(behavior_path_planner): remove setting maximum velocity after lane change #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e change Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
rej55
requested review from
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
purewater0901
approved these changes
May 18, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3756 +/- ##
==========================================
- Coverage 14.46% 14.46% -0.01%
==========================================
Files 1432 1432
Lines 100828 100831 +3
Branches 29764 29768 +4
==========================================
Hits 14585 14585
- Misses 70394 70397 +3
Partials 15849 15849
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rej55
added a commit
to rej55/autoware.universe
that referenced
this pull request
May 19, 2023
…e change (autowarefoundation#3756) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 19, 2023
…e change (#499) fix(behavior_path_planner): remove setting maximum velocity after lane change (autowarefoundation#3756) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With new behavior path planner architecture, the vehicle does not accelerate after lane change if the goal is near.
To fix this problem, I remove setting maximum velocity after lane change.
Related links
Tests performed
Tested in planning simulator.
Before:
cap-.2023-05-18-18-36-40.mp4
After:
cap-.2023-05-18-18-40-21.mp4
Notes for reviewers
Interface changes
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.