Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix invalid access for null drivable area bound #3758

Merged
merged 2 commits into from
May 18, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented May 18, 2023

Description

In generateDrivableArea function, the invalid access for a left/right bound occurs at findNearestSegmentIndexFromLateralDistance when left_bound or right_bound is empty.
I fixed it
image

Related links

(TIERIV Internal Link: Scenario )

Tests performed

I confirmed that the behavior_path_planner becomes not to die when the above rosbag played.

Notes for reviewers

no

Interface changes

no

Effects on system behavior

The behavior_path_planner becomes not to die when the bounds of drivable area are empty.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

… bound

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 18, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 enabled auto-merge (squash) May 18, 2023 10:18
@tkimura4 tkimura4 disabled auto-merge May 18, 2023 10:20
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.07 ⚠️

Comparison is base (add39cb) 15.53% compared to head (a23244e) 14.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
- Coverage   15.53%   14.46%   -1.07%     
==========================================
  Files        1333     1432      +99     
  Lines       94699   100837    +6138     
  Branches    30060    29771     -289     
==========================================
- Hits        14708    14585     -123     
- Misses      63904    70402    +6498     
+ Partials    16087    15850     -237     
Flag Coverage Δ *Carryforward flag
differential 13.26% <0.00%> (?)
total 14.46% <ø> (-1.07%) ⬇️ Carriedforward from 206bc1e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 16.87% <0.00%> (-0.06%) ⬇️

... and 114 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit 632a2ff into autowarefoundation:main May 18, 2023
@tkimura4 tkimura4 deleted the fix/null_drivable_area_bound branch May 18, 2023 11:43
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request May 18, 2023
… bound (autowarefoundation#3758)

* fix(behavior_path_planner): fix invalid access for null drivable area bound

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix message

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants