Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lidar_centerpoint): fix path of image #3764

Merged

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented May 19, 2023

Description

image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
@Shin-kyoto Shin-kyoto requested review from knzo25, yukke42 and a team as code owners May 19, 2023 00:26
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels May 19, 2023
@knzo25
Copy link
Contributor

knzo25 commented May 19, 2023

@Shin-kyoto
Is there a specific reason to avoid uploading images directly into the repository?
Other packages in universe seem to be doing so

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f63c15) 14.51% compared to head (788c9b8) 14.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3764   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files        1439     1439           
  Lines      101307   101307           
  Branches    30061    30061           
=======================================
  Hits        14708    14708           
  Misses      70510    70510           
  Partials    16089    16089           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.51% <ø> (ø) Carriedforward from 3f63c15

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Shin-kyoto
Copy link
Contributor Author

@Shin-kyoto Is there a specific reason to avoid uploading images directly into the repository? Other packages in universe seem to be doing so

I avoid uploading it directly into the repo because it makes git clone slower.
I got an advice from @kminoda. Do you, @kminoda think about it?

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shin-kyoto
Copy link
Contributor Author

Thanks!

Additionally, I think we should move this doc to autoware documentation page because today's situation that README.md is included in launch directory is not good and the way to compare two model is suitable to be written down on documentation.

@Shin-kyoto Shin-kyoto merged commit 3feb007 into autowarefoundation:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants