Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behaivor_path_planner): fixed default value for document in goal_planner #3766

Merged
merged 3 commits into from
May 19, 2023

Conversation

asa-naki
Copy link
Contributor

Description

I have corrected the default value in the goal_planner documentation for behaivor_planner

I checked for different values based on the yaml.file below
https://github.com/autowarefoundation/autoware_launch/tree/main/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/goal_planner

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@asa-naki asa-naki requested a review from kosuke55 May 19, 2023 02:34
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 19, 2023
@shmpwk
Copy link
Contributor

shmpwk commented May 19, 2023

@asa-naki
Thank you for your contribution.
Could you modify the title following the document ?
https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/#rationale_2

The conventional commit this time is "docs".

@asa-naki asa-naki changed the title Fixed default value for document in goal_planner docs(behaivor_path_planner):Fixed default value for document in goal_planner May 19, 2023
@shmpwk
Copy link
Contributor

shmpwk commented May 19, 2023

docs(behaivor_path_planner):Fixed default value for document in goal_planner should be docs(behaivor_path_planner): Fixed default value for document in goal_planner

This is why github-actions semantic-pull-request is failed.

@asa-naki asa-naki changed the title docs(behaivor_path_planner):Fixed default value for document in goal_planner docs(behaivor_path_planner): Fixed default value for document in goal_planner May 19, 2023
@shmpwk
Copy link
Contributor

shmpwk commented May 19, 2023

Could you make pass DCO following the "Details" link?

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.01 🎉

Comparison is base (faf4bd0) 14.51% compared to head (e83c7b1) 15.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3766      +/-   ##
==========================================
+ Coverage   14.51%   15.53%   +1.01%     
==========================================
  Files        1439     1333     -106     
  Lines      101306    94700    -6606     
  Branches    30061    30059       -2     
==========================================
  Hits        14708    14708              
+ Misses      70509    63903    -6606     
  Partials    16089    16089              
Flag Coverage Δ *Carryforward flag
differential 13.26% <ø> (?)
total 15.53% <ø> (+1.01%) ⬆️ Carriedforward from 9b89c18

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 19.89% <ø> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <ø> (ø)

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asa-naki asa-naki changed the title docs(behaivor_path_planner): Fixed default value for document in goal_planner docs(behaivor_path_planner): fixed default value for document in goal_planner May 19, 2023
@asa-naki
Copy link
Contributor Author

It doesn't seem like this PR is the cause of spell-check-differential / spell-check-differential (pull_request) failed.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! You can merge this whenever after the requird CI is passed.

@asa-naki asa-naki merged commit 80d2b73 into main May 19, 2023
@asa-naki asa-naki deleted the fix/goal_planner_document branch May 19, 2023 06:55
@yuasabe yuasabe restored the fix/goal_planner_document branch June 14, 2023 01:58
@yuasabe yuasabe deleted the fix/goal_planner_document branch June 14, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants