Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signal_processing): add a function of low-pass filter #3775

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 20, 2023

Description

Add a function of low-pass filter.
With this, no need to create an instance for low-pass filter in the application side.

Tests performed

unit test

Effects on system behavior

No behavior change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review May 20, 2023 09:45
@takayuki5168 takayuki5168 requested a review from a team as a code owner May 20, 2023 09:45
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ffc8b71) 14.52% compared to head (a6625f9) 14.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
- Coverage   14.52%   14.52%   -0.01%     
==========================================
  Files        1442     1442              
  Lines      101463   101465       +2     
  Branches    30156    30156              
==========================================
  Hits        14741    14741              
- Misses      70584    70586       +2     
  Partials    16138    16138              
Flag Coverage Δ *Carryforward flag
differential 11.06% <0.00%> (?)
total 14.52% <ø> (ø) Carriedforward from ffc8b71

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/signal_processing/src/lowpass_filter_1d.cpp 86.66% <0.00%> (-13.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 29f7fc1 into autowarefoundation:main May 20, 2023
@takayuki5168 takayuki5168 deleted the feat/lowpass-filter-func branch May 20, 2023 10:56
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request May 21, 2023
…oundation#3775)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant