Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signal_processing): add a code owner #3776

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 20, 2023

Description

add a code owner for the signal_processing package.

Tests performed

No need

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ffc8b71) 14.52% compared to head (eaa9968) 14.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3776   +/-   ##
=======================================
  Coverage   14.52%   14.52%           
=======================================
  Files        1442     1442           
  Lines      101463   101463           
  Branches    30156    30156           
=======================================
  Hits        14741    14741           
  Misses      70584    70584           
  Partials    16138    16138           
Flag Coverage Δ *Carryforward flag
differential 11.09% <ø> (?)
total 14.52% <ø> (ø) Carriedforward from ffc8b71

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 marked this pull request as ready for review May 23, 2023 02:29
@takayuki5168 takayuki5168 requested a review from a team as a code owner May 23, 2023 02:29
@takayuki5168
Copy link
Contributor Author

I added code owners. cc @TakaHoribe @rej55 @kyoichi-sugahara

@takayuki5168 takayuki5168 merged commit c0e9c58 into autowarefoundation:main May 23, 2023
@takayuki5168 takayuki5168 deleted the chore/signal-processing-code-owner branch May 23, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant